Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom favicons #41

Closed
auridas330 opened this issue Jul 15, 2022 · 13 comments
Closed

Custom favicons #41

auridas330 opened this issue Jul 15, 2022 · 13 comments
Labels
enhancement New feature or request

Comments

@auridas330
Copy link

Hey!
Any chance of a variable to have our custom favicons for the main jump website? At the moment I had to fork the build to change the favicon.png and rebuild lol.

@daledavies
Copy link
Owner

Absolutely yes! Thank you for reaching out 😀

This has been on my mind for a while as I'm actually not particularly happy with the current favicon anyway. I'm working on a few other things too but will include this in the next release.

@daledavies daledavies added the enhancement New feature or request label Jul 15, 2022
@auridas330
Copy link
Author

Thank you!

@daledavies
Copy link
Owner

Not a problem 😀

@daledavies
Copy link
Owner

I've added support for a custom favicon image in the main branch, I'll create a new release and push new docker images later so I'll let you know when it's done.

@daledavies
Copy link
Owner

Done! If you're using docker you should be able to get this now by pulling either the v1.2.4 or latest tags :)

@daledavies
Copy link
Owner

Also, see the docker/docker-compose and favicon sections of the readme for more details.

@auridas330
Copy link
Author

Hey again, tried following the guide, it created the icon.png in the favicon folder I linked. Tried to replace with my own, but does not seem to do anything.

@daledavies
Copy link
Owner

Browsers can be stubborn when it comes to refreshing the favicon, have you tried clearing cache and ctrl-f5? Maybe open dev tools (F12) and do ctrl-f5 etc.

Also if you browse directly to /assets/images/favicon/icon.png with a clear cache do you see the correct icon?

@daledavies daledavies reopened this Jul 19, 2022
@auridas330
Copy link
Author

Weirdly enough when I browse there there is no favicon image at all
You can have a look yourself at www.sibit.is

@daledavies
Copy link
Owner

I'm only able to use my phone at the minute but I do see one...

Screenshot_20220719-182413

@auridas330
Copy link
Author

Lol im so confused haha
Well it works, maybe need to have a look at what cloudflare is caching. Thank you!

@daledavies
Copy link
Owner

Hey no problem, let me know if I can help

@auridas330
Copy link
Author

After clearing the cloudflare cache it started appearing on my devices too. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants