Skip to content

fix: package type detection when local flag is empty. #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2020
Merged

fix: package type detection when local flag is empty. #27

merged 1 commit into from
Dec 8, 2020

Conversation

@ldez
Copy link
Contributor

@ldez ldez commented Dec 8, 2020 •
edited
Loading

Fixes #23

Related to golangci/golangci-lint#1521

Regression from #22

This was referenced Dec 8, 2020
Merged
Closed
daixiang0
daixiang0 approved these changes Dec 8, 2020
View reviewed changes
Copy link
Owner

@daixiang0 daixiang0 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign your commit, see doc

@ldez
Copy link
Contributor Author

ldez commented Dec 8, 2020 •
edited
Loading

sure, but could you explain why?

@ldez ldez force-pushed the fix/pkg-type branch 2 times, most recently from 5b610a0 to e45e3ea Compare December 8, 2020 04:07
@ldez
Copy link
Contributor Author

ldez commented Dec 8, 2020 •
edited
Loading

@daixiang0 Done

@daixiang0 daixiang0 merged commit 8f975be into daixiang0:master Dec 8, 2020
@ldez ldez deleted the fix/pkg-type branch December 8, 2020 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daixiang0 daixiang0 daixiang0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

upgrading to v0.2.5 results in exit 1 without any other change

2 participants

@ldez @daixiang0