Skip to content

refactor: remove unnecessary strings.Compare #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: remove unnecessary strings.Compare #220

wants to merge 1 commit into from

Conversation

@alexandear
Copy link
Contributor

@alexandear alexandear commented Nov 23, 2024 •
edited
Loading 

❯ golangci-lint run
pkg/parse/parse.go:26:10    gocritic  stringsCompare: suggestion: l[i].Name < l[j].Name
pkg/parse/parse.go:29:9     gocritic  stringsCompare: suggestion: l[i].Path < l[j].Path
pkg/parse/parse.go:25:5     gocritic  stringsCompare: suggestion: l[i].Path == l[j].Path

@alexandear alexandear force-pushed the refactor/strings-compare branch from c1728f0 to b6ed91e Compare November 23, 2024 19:51
@alexandear alexandear force-pushed the refactor/strings-compare branch from b6ed91e to 67f259a Compare June 16, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ccoVeille ccoVeille ccoVeille approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexandear @ccoVeille