-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Status says error but no info about why #233
Comments
This one I can reproduce. The job status is reported by the engine as FAIL:
and the validation report says
But the messages from the job don't reflect what's in the validation report, nor does the job status really give any clues as to what "Error" means. Right now we translate job status "ERROR" and "FAIL" both to "Error". We could instead translate "FAIL" to "Fail" ? Would that always make sense @bertfrees ? |
Yes, that would make sense! An error means that the script was not able to complete. It stopped somewhere in the middle of the conversion. If the status is FAIL, the script completed, but there is an issue with the results. Typically there is some validation that failed, and a validation report is given, and/or the user can find some error or warning messages in the log that indicate what the issue is. |
Keep the Fail status displayed to better indicate a validation issue and not an error occuring during job execution.
Testing feedback from @rachanasinghg for 1.4.0-beta
The text was updated successfully, but these errors were encountered: