Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status says error but no info about why #233

Closed
marisademeglio opened this issue Jun 7, 2024 · 2 comments
Closed

Status says error but no info about why #233

marisademeglio opened this issue Jun 7, 2024 · 2 comments
Milestone

Comments

@marisademeglio
Copy link
Member

Testing feedback from @rachanasinghg for 1.4.0-beta

There are no errors/warnings in messages but the status says "Error".

DP_FalseErrorReport

@marisademeglio
Copy link
Member Author

marisademeglio commented Jun 7, 2024

This one I can reproduce. The job status is reported by the engine as FAIL:

14:35:40.106 › received job data  {
[1]   jobId: '45715faa-7e3d-4930-9a46-1398e6c59908',
[1]   status: 'FAIL',
[1]   href: 'http://127.0.0.1:49152/ws/jobs/45715faa-7e3d-4930-9a46-1398e6c59908',
[1]   nicename: 'DAISY 2.02 Validator',
[1]   log: 'http://127.0.0.1:49152/ws/jobs/45715faa-7e3d-4930-9a46-1398e6c59908/log',
[1]   results: {
[1]     href: 'http://127.0.0.1:49152/ws/jobs/45715faa-7e3d-4930-9a46-1398e6c59908/result',
[1]     mimeType: 'application/zip',
[1]     namedResults: [ [Object] ]
[1]   },
[1]   messages: [ 'removed to keep log cleaner' ],
[1]   progress: 1,
[1]   script: {
[1]     id: 'daisy202-validator',
[1]     href: 'http://127.0.0.1:49152/ws/scripts/daisy202-validator',
[1]     nicename: 'DAISY 2.02 Validator',
[1]     description: 'Validates a DAISY 2.02 fileset.',
[1]     version: '2.0.10',
[1]     homepage: '',
[1]     inputs: [],
[1]     options: []
[1]   }
[1] }

and the validation report says

    expected duration 0 but found 327

    file:/Users/marisa/dev/pipeline-samples/daisy202/Mountains_skip/master.smil

But the messages from the job don't reflect what's in the validation report, nor does the job status really give any clues as to what "Error" means.

Right now we translate job status "ERROR" and "FAIL" both to "Error". We could instead translate "FAIL" to "Fail" ? Would that always make sense @bertfrees ?
https://github.com/daisy/pipeline-ui/blob/main/src/shared/jobName.ts#L3

@bertfrees
Copy link
Member

Yes, that would make sense! An error means that the script was not able to complete. It stopped somewhere in the middle of the conversion. If the status is FAIL, the script completed, but there is an issue with the results. Typically there is some validation that failed, and a validation report is given, and/or the user can find some error or warning messages in the log that indicate what the issue is.

NPavie added a commit that referenced this issue Jun 10, 2024
Keep the Fail status displayed to better indicate a validation issue and not an error occuring during job execution.
@marisademeglio marisademeglio added this to the 1.4 milestone Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants