Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Github build work again #141

Closed
bertfrees opened this issue May 22, 2023 · 1 comment
Closed

Make the Github build work again #141

bertfrees opened this issue May 22, 2023 · 1 comment
Milestone

Comments

@bertfrees
Copy link
Member

The build currently fails because for some reason yarn dist tries to authorize to the Github API which results into this error:

GitHub Personal Access Token is not set, neither programmatically, nor using env "GH_TOKEN"

See e.g. https://github.com/daisy/pipeline-ui/actions/runs/4424934667/jobs/7759361961#step:11:10570.

I wonder whether this can be disabled.

@bertfrees
Copy link
Member Author

Was fixed by commit a9e0734 by adding this:

env:
  GH_TOKEN: ${{ secrets.GH_PIPELINE_TOKEN }}

@marisademeglio Perhaps we can add a little comment explaining that we don't really understand why, but that it was added to avoid that error message?

@marisademeglio marisademeglio added this to the 1.2 milestone Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants