Dodes/#15 angular17 update #16
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 9, 2023 14:11
daiscog
reviewed
Dec 13, 2023
| }) | ||
| export class BasicSmartComponent { | ||
| private readonly service = inject(RandomBreweryService); | ||
| constructor(private readonly service: RandomBreweryService) {} |
There was a problem hiding this comment.
There's no need to stop using the inject function and go back to constructor-based injection. The tests should be fixable by just adding a jest.mock('@angular/core'); at the top of them.
|
Fixed by #18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to use ngx-http-request-state with angular 17