Skip to content

Commit

Permalink
Fix default value of rotate_age
Browse files Browse the repository at this point in the history
It seems that the old value came from `ServerEngine`.

https://github.com/treasure-data/serverengine/blob/v2.3.1/lib/serverengine/daemon_logger.rb#L33

However, actually, `ServerEngine` has nothing to do with the
rotation, and this value `5` is not used at all.

Actually, `Logger::LogDevice` manages the rotation, and the default
value is `7`.

https://github.com/ruby/logger/blob/v1.5.3/lib/logger/log_device.rb#L20

In Fluentd code, the parameters of `Fluent::LogDeviceIO` decides
the behavior of the rotation.

https://github.com/fluent/fluentd/blob/v1.15.3/lib/fluent/supervisor.rb#L563

The parameters of `ServerEngine::DaemonLogger` is meaningless.

https://github.com/fluent/fluentd/blob/v1.15.3/lib/fluent/supervisor.rb#L580-L582

Signed-off-by: Daijiro Fukuda <[email protected]>
  • Loading branch information
daipom committed Mar 11, 2023
1 parent 0c163ad commit 7878773
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion deployment/system-config.md
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ Specifies time format.

| type | default | version |
| :--- | :--- | :--- |
| enum or integer | 5 | 1.13.0 |
| enum or integer | 7 | 1.13.0 |

Specifies `daily`, `weekly`, `monthly` or integer which indicates age of log rotation.

Expand Down

0 comments on commit 7878773

Please sign in to comment.