Allow variables to be passed in at execution time, not only runtime (#37) #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/jq/api.clj
Outdated
| @@ -33,9 +33,9 @@ | |||
| ([^String query opts] | |||
| (let [^JsonQuery json-query (impl/compile-query query) | |||
| ^Scope scope (impl/new-scope opts)] | |||
| (fn ^String [^String data] | |||
| (fn ^String [^String data & {:keys [vars]}] | |||
There was a problem hiding this comment.
to keep it consistent I'd prefer to make this function with two arguments, first for data, and second for the options map.
There was a problem hiding this comment.
Updated accordingly in 3dcaedf
There was a problem hiding this comment.
(that committish is no longer in history as a separate item, but its contents have been folded in when rebasing/squashing this PR onto current main).
charles-dyfis-net
force-pushed
the
issue-37
branch
from
761b571 to
965e180
Compare
dainiusjocas
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.