compile: pass through extra arguments to native-image #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nups
The argument-passthrough change is the primary motivator here, but doing some other cleanups while at it:
- Use `"$@"` to add all arguments to target command line
- Use `exec` so the shell is replaced with native-image in memory, allowing direct signal delivery
- Use `${var?error-if-unset}` syntax instead of multi-line check
- Use `$(<file)` instead of `$(cat file)` to perform the read operation internal to bash instead of spawning a separate `cat` executable
dainiusjocas
approved these changes
Apr 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and other cleanups.
The argument-passthrough change (allowing things like
-H:-CheckToolchainto be directly added to the command line passed tocompile) is the primary motivator here, but doing some other cleanups while at it:"$@"to add all arguments to target command lineexecso the shell is replaced with native-image in memory, allowing direct signal delivery${var?error-if-unset}syntax instead of multi-line check$(<file)instead of$(cat file)to perform the read operation internal to bash instead of spawning a separatecatexecutableAll of these changes should be compatible across all versions of bash in common use, inclusive of the (pre-GPLv3-relicense) bash 3.2 binaries shipped by Apple.