Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Sessions #554

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Support for Sessions #554

wants to merge 8 commits into from

Conversation

SimLV
Copy link

@SimLV SimLV commented May 6, 2024

Now it is possible to keep multiple sessions and to switch between them.

@SimLV
Copy link
Author

SimLV commented May 6, 2024

@dail8859 I am not sure how to fix that MacOS build problem

Copy link
Owner

@dail8859 dail8859 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo changes to submodules to keep the changes to a minimum.

Also remove TODO.md. These normally just end up being false promises to users.

@dail8859
Copy link
Owner

dail8859 commented May 6, 2024

I think the macos-latest was updated and is not able to compile Qt 5.15 as easily. MacOS + Qt 5.15 will probably be dropped unless someone can get the GH action working again.

@SimLV
Copy link
Author

SimLV commented May 6, 2024

Done

@SimLV SimLV requested a review from dail8859 May 6, 2024 19:06
@dail8859
Copy link
Owner

dail8859 commented May 7, 2024

@SimLV Definitely appreciate the PR and nice to see people interested in developing the application more.

My schedule is pretty erratic so I'll try to get to this when I get some free time.

I'm not overly familiar with the Notepad++ session support but I get the general idea of it. If I have any questions I'll let you know.

@SimLV
Copy link
Author

SimLV commented May 7, 2024

I am not sure they had any or not. They are just useful. I added them to NotepadQQ but found project a bit abandoned. So I am going to make some improvements here according to Eating your own dog food principle.

@dail8859
Copy link
Owner

dail8859 commented May 7, 2024

So would you care to describe this new functionality in a few sentences from a user's perspective? E.g. describe a use-case were they would use it, what can they expect from it, etc

That will help me better evaluate the feature and offer any suggestions.

@SimLV
Copy link
Author

SimLV commented May 7, 2024

As a user I may work on different projects.
So I want to have all files related to current project opened.
Then I may decide to switch to another project so all opened files of current project should be saved into this session and closed. While files from second project should be restored.

@SimLV SimLV marked this pull request as draft May 8, 2024 18:53
@SimLV SimLV marked this pull request as ready for review May 9, 2024 22:05
@SimLV
Copy link
Author

SimLV commented Jun 5, 2024

Could you please look at this and #556

@dail8859
Copy link
Owner

dail8859 commented Jun 6, 2024

Apologies for the super long delay. I've been quite busy and only been able to get brief windows of time to put into the project. Hopefully my schedule lightens up soon.

…ssions

# Conflicts:
#	src/NotepadNext/dialogs/MainWindow.ui
#	src/NotepadNext/docks/FolderAsWorkspaceDock.cpp
@lucasvmx
Copy link
Contributor

@dail8859 what about this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants