Adds MobX / MobX React Lite #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Can you please check this? #63 (comment) |
ericmasiello
force-pushed
the
feat/add-mobx
branch
from
8e8a1f1 to
5a354a9
Compare
Contributor
Author
Fixed! |
dai-shi
reviewed
Mar 22, 2023
Owner
dai-shi
left a comment
dai-shi
left a comment
There was a problem hiding this comment.
I could not generate the JSON output when running all the tests together.
I don't know... any error message? Does it work without mobx?
__tests__/all_spec.js
Outdated
|
|
||
| const names = [ | ||
| // 'react-state', | ||
| 'mobx', |
Owner
There was a problem hiding this comment.
Please add it to the end of the array.
added 2 commits
March 22, 2023 08:26
ericmasiello
force-pushed
the
feat/add-mobx
branch
from
5a354a9 to
58c06dd
Compare
Contributor
Author
Disregard. It works OK now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dai-shi I could not generate the JSON output when running all the tests together. Thus, I was unable to update the README with MobX. If I comment out all the other test cases and only run
'mobx'it works as expected. Please advise if you have any guidance on how to update the README for everything.Thank you