refactor: fs-router to use new_createPages

[tylersayshi]

I am confident with the current state of new_createPages, but I'd appreciate help testing this further.

This should come after #1000

This includes the commits from #1000 as well since it needs the fixes included over there. The latest commit on this branch is all that's relevant for this PR though.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
waku	✅ Ready (Inspect)	Visit Preview	Nov 25, 2024 7:48am

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

[tylersayshi]

@dai-shi the e2e test is failing because it seems like the 401 error is no longer caught correctly. Is this meant as a responsibility of NewRouter or ErrorBoundary?

Or do I need to try/catch the createElement call on the page component or something else in new_createPages?

[dai-shi]

it seems like the 401 error is no longer caught correctly.

I'm not sure what broke it. Can you look into it? It's probably my oversight somewhere.

[tylersayshi]

@dai-shi for the error boundary issue here... this screenshot shows in order:

1. a console error for the initial 401 for the route (expected)
2. a log I put in checkStatus where we throw the error from: https://github.com/dai-shi/waku/blob/main/packages/waku/src/minimal/client.ts#L31
3. react console.errors then hits the default error boundary: https://github.com/dai-shi/waku/blob/main/packages/waku/src/router/client.ts#L612-L635

The test fails because the error is being thrown from here: https://github.com/dai-shi/waku/blob/main/packages/waku/src/minimal/client.ts#L208

The Root is a parent of the ErrorBoundary used in the ssr-catch-error test, so it makes sense that this would not be caught.

With all of this, I am not sure how we should adjust:
Should the ErrorBoundary for this test be moved to a custom Root component?
Should we be throwing the error from some other component? Like the Slot for the page component?
Something else?

[dai-shi]

The test fails because the error is being thrown from here

Do you mean fetchRsc throws? It should return a promise without throwing.

[tylersayshi]

The test fails because the error is being thrown from here

Do you mean fetchRsc throws? It should return a promise without throwing.

fetchRsc throws because checkStatus throws inside fetchRSC and the error is not caught inside of fetchRsc

[dai-shi]

With all of this, I am not sure how we should adjust

I think the test should pass without modifying. This feels like a bug in new_defineRouter or NewRouter. 🤔