Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(.github/workflows): change 'npm' to 'pnpm' #232

Closed
wants to merge 2 commits into from

Conversation

sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Dec 30, 2024

  • We are using pnpm, so i change it npm to pnpm

Copy link

codesandbox-ci bot commented Dec 30, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@sukvvon sukvvon marked this pull request as draft December 30, 2024 10:19
@dai-shi
Copy link
Owner

dai-shi commented Dec 30, 2024

It's not a big deal, right? Let me know your thoughts

If this is critical, I can batch update all of my repos with automated scripts.

@sukvvon sukvvon marked this pull request as ready for review December 30, 2024 10:26
@sukvvon
Copy link
Contributor Author

sukvvon commented Dec 30, 2024

It's not a big deal, right? Let me know your thoughts

I just wanted to make it consistent.

If this is critical, I can batch update all of my repos with automated scripts.

This is a matter of detail. Do you have automated scripts?

@sukvvon sukvvon changed the title chore(.github/workflows/ci.yml): change 'npm test' to 'pnpm test' chore(.github/workflows): change 'npm' to 'pnpm' Dec 30, 2024
@dai-shi
Copy link
Owner

dai-shi commented Dec 30, 2024

to make it consistent.

If this is only the reason, I'll do an automated (bash) script. I have more than 30 repos with this config.

Thanks for your suggestion.

@dai-shi dai-shi closed this Dec 30, 2024
@sukvvon sukvvon deleted the chore/change-npm-to-pnpm-in-ci branch December 30, 2024 11:59
@sukvvon
Copy link
Contributor Author

sukvvon commented Dec 30, 2024

@dai-shi

If this is only the reason, I'll do an automated (bash) script. I have more than 30 repos with this config.

May I ask what kind of content is included in the automated (bash) script? I’m simply curious!

@dai-shi
Copy link
Owner

dai-shi commented Dec 30, 2024

It's one liner:

for i in *; do [ -d $i ] && (cd $i; if [ `git branch --show-current` = "main" ] && [ -e .github/workflows/ci.yml ] && git pull && cmp -s ../ci.yml.old .github/workflows/ci.yml; then \cp ../ci.yml.new .github/workflows/ci.yml; git commit -am 'bulk update github workflows'; git push; fi); done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants