Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.0.0-beta2 #577

Merged
merged 2 commits into from
May 18, 2018
Merged

Release v1.0.0-beta2 #577

merged 2 commits into from
May 18, 2018

Conversation

dahlbyk
Copy link
Owner

@dahlbyk dahlbyk commented May 14, 2018

Following on from #542, I've tagged v1.0.0-beta2 and released to PowerShell Gallery. I'm trying to remember if there was a reason I didn't publish v1.0.0-beta1 to the Chocolatey Gallery as well...? Anyway, I'm holding off on that until I convince myself it's not an issue. Maybe I was thinking we shouldn't publish anything 1.0 to Chocolatey until we know how 1.0 is going to work with Chocolatey? Seems reasonable...

@rkeithhill since you tend to kick off the release process with a PR to update the changelog, feel free to name those as release branches and we can do this all at once (e.g. beta1 was tagged in #521).

@rkeithhill
Copy link
Collaborator

feel free to name those as release branches and we can do this all at once

Not sure I follow completely. Do you mean I should name the next CHANGELOG "prep-for-release" branch: release-v1.0.0-beta3 (assuming the next milestone is beta3)?

@dahlbyk
Copy link
Owner Author

dahlbyk commented May 14, 2018

Do you mean I should name the next CHANGELOG "prep-for-release" branch: release-v1.0.0-beta3 (assuming the next milestone is beta3)?

Yes!

And I do think we'll want a beta3. My goals for that release are:

  1. Figure out v1 Chocolatey strategy
  2. Drop ssh-agent stuff into separate module.
  3. Maybe move posh-git code into src/posh-git/? PowerShell still really doesn't like modules living in folders that don't match their name; I currently rename src/ to posh-git/ every time I publish to PS Gallery. A build process (WIP - initial stab at a simple build script #518) could also be the answer to that, but I do think it's important that a fresh clone works as expected (Module no-longer loads after #376 (manifest moved to src/ directory). #467).

@rkeithhill
Copy link
Collaborator

RE #3, a good number of the PS modules I've cloned require a build process so a two-step process of git clone and then run the build.ps1 script isn't too onerous. The other advantage is that it allows you to have multiple versions built and importable at the same time. Plus having the version number in the path is closer to what import-module expects anyway - here's my PS Core install path C:\Users\Keith\Documents\PowerShell\Modules\posh-git\1.0.0.

@dahlbyk
Copy link
Owner Author

dahlbyk commented May 14, 2018

The other advantage is that it allows you to have multiple versions built and importable at the same time.

This feels weird to me, that I might switch to a new posh-git branch but still be using a different version that lives only in a dist/ folder or whatever. Of course, this is very much a "that's not how it's always been" reaction, so I can be convinced. Maybe we should take this discussion back to #467 as a more concrete use case for a direct posh-git clone?

As I alluded to here, I'm still inclined to think of posh-git as a special snowflake. A build step may not be onerous for people who use lots of PowerShell modules, but my suspicion (completely unsupported by data) is that many of our users have close to no other interaction with PowerShell. The more it Just Works™️ for the common case, the better.

Then again, the common case for a fresh clone has always included .\install.ps1. Including a build step before Add-PoshGitToProfile is certainly reasonable, but if folks start to personalize the project will it be natural for them to build before the changes take effect? Maybe I'm not giving our users enough credit?

@dahlbyk dahlbyk merged commit f9f2b4b into master May 18, 2018
@dahlbyk dahlbyk deleted the release-v1.0.0-beta2 branch May 18, 2018 13:53
@dahlbyk dahlbyk mentioned this pull request May 18, 2018
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants