Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update git status to always show untracked files. #557

Merged
merged 2 commits into from
Apr 17, 2018

Conversation

TheSned
Copy link
Contributor

@TheSned TheSned commented Mar 22, 2018

Fixes #556.

This assumes we want to always show untracked files rather than providing an option to include untracked files or not. If this is not the preferred way to fix this issue, let me know what is desired and I can probably implement it.

@dahlbyk
Copy link
Owner

dahlbyk commented Apr 14, 2018

I do think it would be a good idea to make this configurable. Let's add $GitPromptSettings.UntrackedFilesMode to allow providing a -u value, defaulting to $null to preserve existing behavior. If a value is provided (all, normal or no), it should be added to the git status call. Does that seem reasonable?

Thanks for the proposal, and sorry for the absurd delay in reviewing this!

@TheSned
Copy link
Contributor Author

TheSned commented Apr 14, 2018

Yes, that sounds reasonable. I'll update it when I get a chance.

@dahlbyk dahlbyk merged commit 5e1c907 into dahlbyk:master Apr 17, 2018
@dahlbyk
Copy link
Owner

dahlbyk commented Apr 17, 2018

Great - thanks!

@rkeithhill
Copy link
Collaborator

Do we have a way to tag this commit for merging to develop?

@dahlbyk dahlbyk added this to the v0.7.2 milestone Apr 17, 2018
@TheSned TheSned deleted the AlwaysShowUntrackedFiles branch April 17, 2018 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prompt will not display untracked files if status.showUntrackedFiles is set to "no"
3 participants