Lookup HtmlColors before ConsoleColors #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out ConsoleColors are a lot easier to specify than HtmlColors (that happen to match ConsoleColor names). Add PSEdition_Core tag so that posh-git shows up if someone searches for that tag - https://www.powershellgallery.com/items?q=tags%3Apsedition_core&x=0&y=0
lzybkr
reviewed
Jan 18, 2018
src/AnsiUtils.ps1
Outdated
| $color = $ColorTranslatorType::FromHtml($color) | ||
| } | ||
| elseif ($null -ne ($color -as [System.ConsoleColor])) { | ||
| $color = [System.ConsoleColor]$color |
There was a problem hiding this comment.
This is the anti-pattern of converting twice - you should either use -as or the cast, but not both.
There was a problem hiding this comment.
OK, caught me being lazy but at least we fixed the bug where [System.ConsoleColor]::Black (value of 0) was not registering as a ConsoleColor. :-)
Actually this found a bit of a corner case issue where a string that was not a valid HTML color name BUT a valid ConsoleColor name (DarkYellow) wouldn't work because we blew by the ConsoleColor code straight to the catch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out ConsoleColors are a lot easier to specify than HtmlColors (that happen to match ConsoleColor names).
Add
PSEdition_Coretag so that posh-git shows up if someone searches for that tag - https://www.powershellgallery.com/items?q=tags%3Apsedition_core&x=0&y=0