Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.7.2 #522

Merged
merged 19 commits into from
Apr 20, 2018
Merged

Release v0.7.2 #522

merged 19 commits into from
Apr 20, 2018

Conversation

dahlbyk
Copy link
Owner

@dahlbyk dahlbyk commented Jan 10, 2018

I've pulled a few backward-compatible changes down from develop. In particular:

I also split off the changelog entries from #521 that apply to this release.

mikesigs and others added 7 commits January 9, 2018 23:32
Related #478. This is a better fix. By specifying the CommandType as Application we can continue looking for `git` (exe or cmd) but avoiding any potential aliases the user may have created for "git".
Allow advanced users to invoke the $scriptblock from their own prompt functions.
And export Get-PromptPath to expose our default path logic
@dahlbyk
Copy link
Owner Author

dahlbyk commented Jan 10, 2018

Copy link
Collaborator

@rkeithhill rkeithhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dahlbyk
Copy link
Owner Author

dahlbyk commented Jan 12, 2018

I can't think of anything else blocking finalizing this release. Am I missing anything?


# TODO: REMOVE BEFOE RELEASE
PreReleaseVersion = 'pre0'
Prerelease = 'pre1'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to update this or do you do that manually before you publish?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'll drop this and fix all the other -pre1 references before I commit and tag v0.7.2.

@rkeithhill
Copy link
Collaborator

Nothing that I'm aware of. Although the README needs an update to at least mention that another version exists to support ANSI and PS Core 6.

README.md Outdated
- `develop` includes breaking changes, toward [v1.0](https://github.com/dahlbyk/posh-git/issues/328).
( [README](https://github.com/dahlbyk/posh-git/blob/develop/README.md)
• [CHANGELOG](https://github.com/dahlbyk/posh-git/blob/develop/CHANGELOG.md) )
- Supports PowerShell 5 and PowerShell Core 6
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the first one to Windows PowerShell 5.x - includes 5.0 and 5.1.

README.md Outdated
@@ -22,9 +22,12 @@ You can also tab complete remote names and branch names e.g.: `git pull or<tab>
- `master` avoids breaking changes, maintaining v0.x.
( [README](https://github.com/dahlbyk/posh-git/blob/master/README.md)
• [CHANGELOG](https://github.com/dahlbyk/posh-git/blob/master/CHANGELOG.md) )
- Supports PowerShell 3+
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should be Windows PowerShell 3+ to help make distinction between Windows PowerShell and PowerShell Core.

@dahlbyk dahlbyk changed the base branch from master to v0 April 20, 2018 02:00
@dahlbyk
Copy link
Owner Author

dahlbyk commented Apr 20, 2018

I'm updating this changelog for an official v0.7.2 release before I shift focus to finalizing v1.

Move v0 off master

As perhaps the final v0.x release, I have updated the readme to refer to v0 instead of master as that development branch. Going forward, I'm considering discarding master altogether in favor of v1 as the repo's default branch; future breaking changes would target a v2 branch when the time comes. Thoughts?

@rkeithhill
Copy link
Collaborator

Personally, I'd prefer that we just rename develop to master. I think most contributors coming to the repo will expect a master branch. Having a v0 branch for servicing v0.x sounds like the way to go to me.

@dahlbyk dahlbyk added this to the v0.7.2 milestone Apr 20, 2018
@dahlbyk
Copy link
Owner Author

dahlbyk commented Apr 20, 2018

@rkeithhill (or anyone!) can I get a final sanity check here before I tag v0.7.2 and release this?

@rkeithhill
Copy link
Collaborator

Sure. I have to drive home from my son's swim practice. I'll test it in about 30 minutes.

@dahlbyk
Copy link
Owner Author

dahlbyk commented Apr 20, 2018

Rearrange readme versions

I had forgotten about this change, which I had started on an old computer (9c37c76#r161387410). Anyway, it seems like an improvement for this branch, even if it will change substantially in v1.

@rkeithhill
Copy link
Collaborator

LGTM. I've been testing the various new features / fixes in the release. So far, it all looks goodl

Apparently I accidentally published v0.7.2 back in January
@dahlbyk
Copy link
Owner Author

dahlbyk commented Apr 20, 2018

Bump to v0.7.3

Apparently I accidentally published v0.7.2 back in January

Sigh.

v0.7.3 has been published to Chocolatey and PowerShell Gallery.

@dahlbyk dahlbyk merged commit bfdcf99 into v0 Apr 20, 2018
@dahlbyk dahlbyk deleted the release-v0.7.2 branch April 20, 2018 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants