Repository navigation
fix(kanban): add fail-closed embedded dispatcher quiesce - #10
Merged
Merged
Conversation
Acting lane: Talos builder Issue: dagyrox/or7-platform#221 Consumer PR: dagyrox/or7-platform#223 Hermes Kanban: t_c349e5f1 / run 173 Work packet: docs/agentic-operations/work-packets/2026-08-21-hermes-kanban-lifecycle-isolation.md
Acting lane: Talos builder Authority: Athena architecture/release review Issue: dagyrox/or7-platform#221 Provider PR: #10 Hermes Kanban: t_48ce0768 / run 176 Predecessor: 6882b31 Review artifact: /tmp/athena-hermes-pr10-exact-head-6882b314.md (SHA-256 3cbf369b32f23b5f6ef5149e48904fbea32314895de06afa91b1a4ce0bf996af) Work packet: docs/agentic-operations/work-packets/2026-08-21-hermes-kanban-lifecycle-isolation.md
[Talos][Or7 NousResearch#221][Hermes PR #10] Reject bool/float protocol and PID values across owner, request, and ACK trust-boundary validation. Malformed owner state now makes the requester fail closed without control writes; deterministic red-green coverage preserves valid different-generation behavior.\n\nHermes Kanban: t_832c4f2d / run 178\nWork packet: /root/projects/or7-platform/.worktrees/issue221-activation-freeze-repair/docs/agentic-operations/work-packets/2026-08-21-hermes-kanban-lifecycle-isolation.md\nAuthority: Athena; Control: Hermes; Acting lane: Talos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the provider-side, fail-closed quiescence boundary required by dagyrox/or7-platform#221 to unblock consumer dagyrox/or7-platform#223.
hermes kanban dispatcher-quiesce --pid <MainPID> --timeout <seconds> --jsonasyncio.to_thread(...)work before acknowledging, including under repeated watcher cancellationAthena exact-head repairs
This successor preserves the malformed-request repair against predecessor
6882b314c0d79e94a6efe085dfbd44c4a33dc612and repairs Athena's strict-typing finding against rejected headb2cf303f9216e99368b06d2b4b3d69578d29d034:owner_idwith missing or contradictoryowner_pidas invalidintvalues for protocol and PID fields across owner, request, and ACK trust-boundary validators, excluding booleans, floats, and integer subclassesread_dispatcher_owner()reject malformed owner records and makes the requester returnindeterminatewithout writing request/ACK filestrue,false,1.0, strings, missing/unsupported values; owner/request/ACK PID booleans/floats; malformed request/ACK variants; and valid different-generation preservationSafety contract
A successful result:
{"ok": true, "state": "quiesced", "owner_pid": 1234, "owner_mode": "embedded"}means the targeted embedded owner acknowledged quiescence only after its active dispatcher tick drained. Repeated requests are idempotent.
not_running,not_owner,timeout,indeterminate, andinvalid_requestreturn nonzero and must stop the caller's cutover.Verification at successor head
Successor head:
3ae01d0910d027eb9dca3a73aa52c6551a901ab6Successor tree:
6526ec36a155d8df9da4e4476e8940303a7090ebscripts/run_tests.shwrapper under the installed Hermes venv (the ignored worktree.venvwas temporarily moved aside and restored without installation or dependency mutation), focused four-file Issue fix(security): block path traversal in skill_view file_path parameter NousResearch/hermes-agent#221 matrix: 88 passed, 0 failedscripts/run_tests.shwrapper over all 47*kanban*.pyfiles: 1205 passed, 2 failed; log SHA-256c53cc6107e1b73f3970b2bf6d5c1c81117c2f15d7ab427f2468c9f139d5e91e6; the two failures are unchanged provider-[Talos] Isolate Kanban workers from gateway lifecycle (or7-platform#221) #9 environment/baseline cases:tests/hermes_cli/test_kanban_db.py::test_connect_falls_back_to_delete_on_locking_protocoltests/hermes_cli/test_kanban_db_repair.py::test_wal_checkpoint_truncates_wal_file93b549ad9c8ab58e43210b6a898bab918c212695e743375a1e0268c6ab21fa7agit diff --check: passed0statuses,0check runs), reported honestly under the fork waiver established by the predecessor reviewExact-head review binding
/tmp/athena-hermes-pr10-exact-head-6882b314.md3cbf369b32f23b5f6ef5149e48904fbea32314895de06afa91b1a4ce0bf996af/tmp/athena-hermes-pr10-rereview-b2cf303f.md5044b20a2c14212a77175da8f29e628571e3cad938849ee18bc11fcefaf5fa3b(sidecar verified before edits)b2cf303f9216e99368b06d2b4b3d69578d29d034/dc284c345618dbd5da591210eb826cf1bc76a2ba3ae01d0910d027eb9dca3a73aa52c6551a901ab6/6526ec36a155d8df9da4e4476e8940303a7090eb/tmp/talos-hermes-pr10-strict-typing-3ae01d0910.md9cd4b943883591aecd6917cdeef0a28ca8f6e6f5cbb5d5318a2e119ed583b8f0(sidecar verified)Provenance
dagyrox/or7-platform#221dagyrox/or7-platform#223(still frozen pending its separate repair/review)t_832c4f2d/ run178t_c349e5f1/173t_2c5cf8e5/177docs/agentic-operations/work-packets/2026-08-21-hermes-kanban-lifecycle-isolation.md83d466e443f8c4e6d1526cebd90c9b0cfceb22cbNo merge, deployment, installation, activation, configuration/service mutation, gateway restart, or live witness is authorized or performed by this repair.