Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for the time zone configurations #698

Merged
merged 4 commits into from
Nov 6, 2024
Merged

Conversation

yohamta
Copy link
Collaborator

@yohamta yohamta commented Nov 6, 2024

This PR Adds the documentation about tz configuration via config file and environment variables. Also includes some refactoring regarding time zone handling.

  • Added the documentation for tz
  • Refactored the scheduler to use the specified timezone setting
  • Refactored the environment config key to DAGU_TZ

@yohamta yohamta merged commit 4bbcc71 into main Nov 6, 2024
5 checks passed
@yohamta yohamta deleted the tz-documents branch November 6, 2024 13:50
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 28.20513% with 28 lines in your changes missing coverage. Please review.

Project coverage is 61.97%. Comparing base (93c3710) to head (e6fb91b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/config/config.go 0.00% 17 Missing ⚠️
internal/scheduler/scheduler.go 35.29% 10 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #698      +/-   ##
==========================================
- Coverage   62.10%   61.97%   -0.14%     
==========================================
  Files          53       53              
  Lines        5215     5228      +13     
==========================================
+ Hits         3239     3240       +1     
- Misses       1723     1734      +11     
- Partials      253      254       +1     
Files with missing lines Coverage Δ
internal/scheduler/entryreader.go 67.82% <100.00%> (ø)
internal/scheduler/scheduler.go 64.49% <35.29%> (+2.08%) ⬆️
internal/config/config.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93c3710...e6fb91b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant