Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove container if workflow is cancelled #634

Merged
merged 1 commit into from
Jul 28, 2024
Merged

Remove container if workflow is cancelled #634

merged 1 commit into from
Jul 28, 2024

Conversation

x4204
Copy link
Contributor

@x4204 x4204 commented Jul 26, 2024

Fixes: #633

The container is now cleanly removed if workflow is cancelled

time=2024-07-26T23:15:46.401+02:00 level=INFO msg="Stop request received"
time=2024-07-26T23:15:46.454+02:00 level=INFO msg="Sending signal to running child processes" signal=terminated
time=2024-07-26T23:15:46.456+02:00 level=INFO msg="Waiting for child processes to exit..."
2024/07/26 23:15:46 Sending terminated signal to run
time=2024-07-26T23:15:46.881+02:00 level=INFO msg="Step execution finished" step=run status=canceled
time=2024-07-26T23:15:46.881+02:00 level=INFO msg="Workflow execution finished" status=canceled

yohamta
yohamta approved these changes Jul 28, 2024
View reviewed changes
Copy link
Collaborator

@yohamta yohamta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨✨✨LGTM✨✨✨, thank you very much!

@yohamta yohamta merged commit 0ad4f5b into dagu-org:main Jul 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yohamta yohamta yohamta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker container not being removed after workflow is cancelled
2 participants
@x4204 @yohamta