Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复 DAG 环路检测 #427

Merged
merged 1 commit into from
Apr 1, 2023
Merged

fix: 修复 DAG 环路检测 #427

merged 1 commit into from
Apr 1, 2023

Conversation

1005281342
Copy link
Contributor

@1005281342 1005281342 commented Apr 1, 2023

有 spec 如下:

steps:
  - name: a
    command: echo hello

  - name: b
    command: echo hello
    depends:
      - a

  - name: c
    command: echo hello
    depends:
      - b

  - name: d
    command: echo hello
    depends:
      - b

  - name: e
    command: echo hello
    depends:
      - f

  - name: g
    command: echo hello
    depends:
      - f
      - b

  - name: h
    command: echo hello
    depends:
      - e
      - g
      - f

  - name: i
    command: echo hello
    depends:
      - f


  - name: j
    command: echo hello
    depends:
      - f

  - name: f
    command: echo hello
    depends:
      - d

  - name: k
    command: echo hello
    depends:
      - b

  - name: o
    command: echo hello
    depends:
      - b

  - name: p
    command: echo hello
    depends:
      - b

  - name: q
    command: echo hello
    depends:
      - b
      - f
      - k
      - o
      - p

当前版本(v1.10.3),提示 cycle detected

本次提交修复后:

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.07 🎉

Comparison is base (b0a4fd8) 81.25% compared to head (73bc2e2) 81.32%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #427      +/-   ##
==========================================
+ Coverage   81.25%   81.32%   +0.07%     
==========================================
  Files          30       30              
  Lines        3345     3358      +13     
==========================================
+ Hits         2718     2731      +13     
  Misses        488      488              
  Partials      139      139              
Impacted Files Coverage Δ
internal/scheduler/graph.go 80.91% <100.00%> (+2.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@yohamta yohamta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@1005281342 Great work on fixing the bug in the cycle detection code! Your contribution is greatly appreciated and will ensure the reliability and stability of Dagu. Thank you for taking the time to investigate and resolve the issue. Keep up the good work!

@yohamta yohamta merged commit f851bd0 into dagu-org:main Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants