-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for env variables in executor config #674
Comments
@yohamta What do you think? I think this is a good idea.
|
Thank you for submitting this issue and suggestions. I completely agree that this would be a valuable feature. To implement this, we will need to make the following changes:
If you have any thoughts on this implementation plan or additional considerations, please feel free to share them. |
@yohamta Hi! I will try to work on this ! |
Thank you @halalala222, please feel free to ask if there's any questions! |
@yohamta add support for environment variable expansion in the executor config for all executor types available Is it necessary to add this environment variable to executors other than the SSH executor? |
Hi @halalala222, I made a mistake earlier - we actually only need support for environment variable expansion in the SSH executor right now. Sorry for the confusion. |
It would be very useful if one were able to use environment variables when configuring an executor - an example of desired usage with the ssh executor:
I'm not familiar enough with Go to neither understand the complexity nor attempt a PR of it.
The text was updated successfully, but these errors were encountered: