[components] Refactor component load behavior #27181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 16, 2025
OwenKephart
force-pushed
the
01-16-_components_refactor_component_load_behavior
branch
from
977ee0c to
3c6e30f
Compare
benpankow
approved these changes
Jan 17, 2025
| component_file_model=obj, | ||
| source_position_tree=parsed.source_position_tree, | ||
| ) | ||
|
|
||
| def get_component_type(self, registry: ComponentTypeRegistry) -> type[Component]: |
There was a problem hiding this comment.
nit: get_ belies that this is doing some real work (parsing python files), maybe resolve_component_type?
There was a problem hiding this comment.
might be worth a brief docstr to explain that this does local lookup in addition to the expected registry lookup
OwenKephart
force-pushed
the
01-16-_components_explicitly_pass_params
branch
from
b402c39 to
339fe7a
Compare
OwenKephart
force-pushed
the
01-16-_components_refactor_component_load_behavior
branch
from
3c6e30f to
8e92e27
Compare
|
Deploy preview for dagster-docs-beta ready! Preview available at https://dagster-docs-beta-1oazby577-elementl.vercel.app Direct link to changed pages: |
OwenKephart
force-pushed
the
01-16-_components_refactor_component_load_behavior
branch
from
8e92e27 to
82497f2
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| return MyNestedComponentSchema | ||
|
|
||
| @classmethod | ||
| def load(cls, params: MyComponentSchema, context: ComponentLoadContext) -> Self: |
There was a problem hiding this comment.
The type hint for params should be MyNestedComponentSchema to match the schema type returned by get_schema(). This appears to be a copy/paste error from the class above.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
OwenKephart
force-pushed
the
01-16-_components_explicitly_pass_params
branch
from
339fe7a to
145aa32
Compare
OwenKephart
force-pushed
the
01-16-_components_refactor_component_load_behavior
branch
2 times, most recently
from
5ee4d47 to
fcca097
Compare
OwenKephart
changed the base branch from
01-16-_components_explicitly_pass_params
to
graphite-base/27181
OwenKephart
force-pushed
the
01-16-_components_refactor_component_load_behavior
branch
from
fcca097 to
5f00ea4
Compare
OwenKephart
deleted the
01-16-_components_refactor_component_load_behavior
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This moves the load method onto the individual DeclNode classes, which simplifies the logic a bit and just generally is a bit better organized.
The impetus for this is cleaning up the house a bit in preparation for adding a PythonDeclNode
How I Tested These Changes
Changelog
NOCHANGELOG