Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up #69

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Clean up #69

merged 2 commits into from
Oct 22, 2024

Conversation

191220029
Copy link
Collaborator

No description provided.

@191220029
clean up
65f2ef6 
Signed-off-by: Xiaolong Fu <[email protected]>
aminya
aminya requested changes Oct 19, 2024
View reviewed changes
Copy link
Collaborator

@aminya aminya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why archiving the code?

@191220029
Copy link
Collaborator Author

Why archiving the code?

We are planning to refactor Dagrs using the flow-based programming paradigm. Our plan is as follows
https://docs.google.com/presentation/d/1UP3OlzJwP9pjBcbASys3m-gQP7MlONyU/edit?usp=sharing&ouid=109824571352106516794&rtpof=true&sd=true

@genedna genedna requested a review from aminya October 19, 2024 07:18
@genedna genedna enabled auto-merge October 19, 2024 07:19
@191220029
Copy link
Collaborator Author

And we also provide a brief introduction about our plan in docs/upgrade.md
Welcome to join our discord channel to discuss about the refactoration: https://discord.gg/xaHZXwnn

@aminya
Copy link
Collaborator

aminya commented Oct 19, 2024

I think it's better to do this in a temporary dev branch instead of the actual main branch in case we have to apply fixes to the main while development happens.

@genedna
Copy link
Member

genedna commented Oct 19, 2024

I think it's better to do this in a temporary dev branch instead of the actual main branch in case we have to apply fixes to the main while development happens.

I am a fan of trunk-base development, and I hope to rewrite dagrs from the beginning and cross-review each PR to help the engine have better code quality.

@genedna
Copy link
Member

genedna commented Oct 19, 2024

#70

@genedna genedna added this to the 0.4.0 milestone Oct 19, 2024
@aminya
Copy link
Collaborator

aminya commented Oct 21, 2024

So if you don't wanna keep the original code in main and start a new branch, why not just remove the current code. Why move them?

@genedna genedna merged commit 3ab7009 into dagrs-dev:main Oct 22, 2024
191220029 pushed a commit to 191220029/dagrs-NJU-fxl that referenced this pull request Oct 25, 2024
@genedna @191220029
Merge pull request dagrs-dev#69 from 191220029/main
6db52ea 
Clean up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aminya aminya aminya requested changes

@genedna genedna genedna approved these changes

@A-Mavericks A-Mavericks A-Mavericks approved these changes

Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@191220029 @aminya @genedna @A-Mavericks