Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ErrWithExitCode output #68

Merged
merged 6 commits into from
Aug 26, 2024
Merged

Fix ErrWithExitCode output #68

merged 6 commits into from
Aug 26, 2024

Conversation

kdesjard
Copy link
Contributor

A few commits to:

  • update logging in the case of an execution error so that it doesn't output a linefeed
  • update the error output in the case of ErrWithExitCode so that the code is displayed if present
  • change the log level in src/task/cmd.rs to show the cmd and args being run at the info level
  • add a test for ErrWithExitCode

@genedna genedna enabled auto-merge August 18, 2024 03:06
auto-merge was automatically disabled August 24, 2024 17:25

Head branch was pushed to by a user without write access

@genedna genedna enabled auto-merge August 26, 2024 14:30
@genedna genedna merged commit 62a6d11 into dagrs-dev:main Aug 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@genedna genedna genedna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kdesjard @genedna @Kris-Desjardins