Yaml read from str #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kdesjard , I would appreciate your contribution very much. When I wanted to merge the PR, I noticed that the DCO needed to be signed. Please follow the DCO & PGP and Rebase the branch, rebase the commits. |
kdesjard
force-pushed
the
yaml_read_from_str
branch
from
58a1dba to
dbd6d0b
Compare
…dd an impl to convert io errors to parse errors Signed-off-by: kdesjard <[email protected]>
Signed-off-by: kdesjard <[email protected]>
…g slice using the updated Parser trait Signed-off-by: kdesjard <[email protected]>
…lice Signed-off-by: kdesjard <[email protected]>
…ctly with a string slice Signed-off-by: kdesjard <[email protected]>
Signed-off-by: kdesjard <[email protected]>
kdesjard
force-pushed
the
yaml_read_from_str
branch
from
dbd6d0b to
0590f35
Compare
|
Fixed |
genedna
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to allow for reading of tasks from a file or from a string. This introduces a breaking change to the Parser trait.
For your consideration.
Thanks, Kris.