fix!: avoid cloning the input/outputs + remove anymap2 #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amin Yahyaabadi <[email protected]>
Based on benchmarks, this is 8.5% faster
```
Running benches/compute_dag_bench.rs (target/release/deps/compute_dag_bench-0054d485c319d409)
compute dag time: [455.21 µs 456.03 µs 456.87 µs]
change: [-8.7821% -8.4917% -8.2036%] (p = 0.00 < 0.05)
Performance has improved.
Found 421 outliers among 4000 measurements (10.53%)
281 (7.03%) high mild
140 (3.50%) high severe
```
Signed-off-by: Amin Yahyaabadi <[email protected]>
Signed-off-by: Amin Yahyaabadi <[email protected]>
Signed-off-by: Amin Yahyaabadi <[email protected]>
Signed-off-by: Amin Yahyaabadi <[email protected]>
Signed-off-by: Amin Yahyaabadi <[email protected]>
Signed-off-by: Amin Yahyaabadi <[email protected]>
BREAKING this returns an Arc<T> instead of T in the get_result methods Signed-off-by: Amin Yahyaabadi <[email protected]>
|
Thanks. Fixed the conflict! |
genedna
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents cloning of the input/outputs and removes anymap2 in favour of the standard
Arc<dyn Any + ...>>.I was able to find this performance issue via profiling #43. The profiling shows that this reduced the time from 690 ms to 591 ms. As you see, the
Hashbrown::clonemethod is gone now.After optimizations:
Before optimizations:
Benchmarks
The benchmarks also show an 8.5% improvement