Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk: Bump engine dependency to v0.9.5 #6309

Merged
merged 2 commits into from
Dec 21, 2023
Merged

sdk: Bump engine dependency to v0.9.5 #6309

merged 2 commits into from
Dec 21, 2023

Conversation

jedevc
Copy link
Member

@jedevc jedevc commented Dec 21, 2023

This PR was not auto-generated. The v0.9.5 publish job failed: https://github.com/dagger/dagger/actions/runs/7289942610/job/19865637361. (Ideally this shouldn't happen, feels like we should always open this PR, even if the prior step failed).

However, only nix failed, everything else succeeded - so I've just opened this PR manually to continue with the release.

(The nix issue seems related to permissions, I suspect that RELEASE_DAGGER_CI_TOKEN doesn't have access to write to https://github.com/dagger/nix)

@jedevc jedevc requested a review from gerhard December 21, 2023 16:19
@jedevc jedevc requested review from a team as code owners December 21, 2023 16:19
@jedevc jedevc marked this pull request as draft December 21, 2023 16:19
Signed-off-by: Justin Chadwell <[email protected]>
@jedevc jedevc marked this pull request as ready for review December 21, 2023 16:23
@gerhard
Copy link
Member

gerhard commented Dec 21, 2023

Great catch @jedevc!

I have just added write access for dagger-ci to https://github.com/dagger/nix repo.

It looks like we will need to manually bump this @sagikazarmark . Should work next time!

Copy link
Member

@gerhard gerhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jedevc jedevc merged commit 037520e into main Dec 21, 2023
91 checks passed
@jedevc jedevc deleted the bump-engine branch December 21, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants