Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump node from 16.10 to 17.0.1 in /web #11

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 8, 2021

Bumps node from 16.10 to 17.0.1.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps node from 16.10 to 17.0.1.

---
updated-dependencies:
- dependency-name: node
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file docker Pull requests that update Docker code labels Nov 8, 2021
@daaang
Copy link
Owner

daaang commented Nov 8, 2021

Node 17 isn't compatible with webpack 4, and create react app isn't compatible with webpack 5, but they are working on it. I could eject and manage all the dependencies on my own, but I'm in no hurry, and it looks like CRA should be compatible with webpack 5 soon, and then I can just upgrade. Until then, I'll leave this open.

daaang added a commit that referenced this pull request Nov 8, 2021
This way, if e.g. the unit tests pass but the acceptance tests fail (as
happened in PR #11), that information will be evident before
investigating the specific problem.
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 10, 2021

Superseded by #12.

@dependabot dependabot bot closed this Nov 10, 2021
@dependabot dependabot bot deleted the dependabot/docker/web/node-17.0.1 branch November 10, 2021 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file docker Pull requests that update Docker code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant