add file.stat() #81
Merged
add file.stat() #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
quick attempt at adding #80, please let me know if you need any changes or a different approach. |
d5
requested changes
Feb 5, 2019
There was a problem hiding this comment.
This is great!! Left some comments. Please update documentation too!
|
let me know how this looks, if good I'll open a followup for readall |
|
Yeah, this is good!!
|
|
Addressed the tests and docs - prefer other functions in a separate PR |
ripienaar
commented
Feb 6, 2019
| - `mtime`: time the file was last modified | ||
| - `size`: file size in bytes | ||
| - `mode`: file permissions as in int, comparable to octal permissions | ||
| - `directory`: boolean indicating if the file is a directory |
There was a problem hiding this comment.
wasnt sure how you want these as the other examples only show methods so just tried this to see
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.