Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin d3-selection dep to 3.0.0 #274

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

OliverMadine
Copy link

@OliverMadine OliverMadine commented Apr 30, 2024

zoom.transform uses selection.interrupt

which conflicts if not using d3-selection 3.0.0 onwards

which may conflict with different versions of d3-selection installed

@mbostock
Copy link
Member

That doesn’t seem right. First, selection.interrupt is provided by d3-transition, not d3-selection. And second, selection.interrupt has existed since version 0.0.5 of d3-transition; see d3/d3-transition@46bbcd6. You probably have a different issue which is duplicate versions of d3-selection installed, preventing d3-transition from modifying d3.selection.prototype.

@OliverMadine
Copy link
Author

OliverMadine commented Apr 30, 2024

Ah my bad, I took this comment thread at face value.

fwiw, the issue is as you described with this structure (image from here)
image

Upgrading d3-selection does work, but ideally we would have a build conflict fail somewhere ☹️

preventing d3-transition from modifying selection.prototype.

I'm mostly questioning this part

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants