Modify time zone parsing (%Z) to accept any ISO 8601 compatible time zone format #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zone format. This includes: * +-hhmm (the only previously accepted format) * +-hh:mm * +-hh * Z (for UTC) This addresses an old issue from the single module version 3.x: d3/d3#2055
| return /^[+-]\d{4}$/.test(string = string.slice(i, i + 5)) | ||
| ? (d.Z = -string, i + 5) // sign differs from getTimezoneOffset! | ||
| : -1; | ||
| var n = /^(Z)|([+-]\d\d)(?:\:?(\d\d))?/.exec(string.slice(i)); |
There was a problem hiding this comment.
Since the maximum number of possible matching characters here is 6 ("+12:34"), I think we want string.slice(i, i + 6) here for efficiency’s sake.
|
Thanks for resubmitting this. |
* Shortening the candidate string for faster regex execution. * Using smarter conditions to do math instead of string concatenation when there are no minutes in the TZ specifier.
|
Made both those changes, so this should perform a little better :) |
mbostock
added a commit
that referenced
this pull request
Oct 18, 2015
Modify time zone parsing (%Z) to accept any ISO 8601 compatible time zone format
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of a pull request from the single-module version of D3 3.x (d3/d3#2480). I hadn’t realized the work of splitting up modules was happening at the time I proposed it. Let me know if this is unwelcome or not helpful.
This includes parsing support for:
…and addresses an old issue that myself and several others have run into: d3/d3#2055