allow minus sign to be configured in locale #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we call it “minus” rather than “minusSign”? |
mbostock
approved these changes
Sep 5, 2019
|
Thank you for building this awesome piece of software 💐 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new property to the locale:
minusSign.Using this property the character used as the prefix for negative numbers can be specified in the locale. The default is defined as the current character minus-hyphen
U+002D.This implements the idea in the issue #62 that it should be possible to override the character used in the locale.
All the tests pass, although I haven't added a new case to check if the new
minusSignlocale prop gets used everywhere as it should. Please advise if you want me to do something else/more here.