-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create emit before we use it; make move accept an event. #84
Conversation
src/brush.js
Outdated
@@ -227,7 +227,7 @@ function brush(dim) { | |||
function tween(t) { | |||
state.selection = t === 1 && selection1 === null ? null : i(t); | |||
redraw.call(that); | |||
emit.brush(); | |||
emit.brush(event); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn’t feel appropriate to use the event here because time has passed—we’re now inside a transition.
This seems to: - fix #83 - possibly fix d3/d3-zoom#198 - help with d3/d3-zoom#222
Hello, with 3.0.0, I have this following error, Is it a similar problem of this fix ? on : function touchended(event) { |
Hard to tell—can you give a bit more context? |
I have this error on a brush with a filter. `this.brush = d3Brush this.graphique.append('g').attr('class', 'brush').attr('id', this.indexGraphe).call(this.brush); I will try to do with your sample to reproduce. Thanks |
I think maybe .filter(event => event.touches?.length === 2) is filtering
out the events that start the gesture? In that case I can see how you would
get into this situation where the emitter has not been "blessed" with a
touchended property
|
OK ! I understood...So It's perhaps a problem with this filter. I will investigate on a workaround. |
This seems to: