Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the slideshow interval to be less than 1 second #1393

Merged
merged 3 commits into from
Jul 26, 2022
Merged

Allow the slideshow interval to be less than 1 second #1393

merged 3 commits into from
Jul 26, 2022

Conversation

BenHUET
Copy link
Contributor

@BenHUET BenHUET commented Jul 17, 2022

This PR allows users to set the slide show's interval with milliseconds precision thus allowing them to set an interval lower than 1s. It covers this feature request : #1155

untitled

This uses a Stopwatch for the precision but the check is still done by the timSlideShow_Tick method with the timSlideShow.Interval now set to 1ms. 1ms will probably be too fast for Windows hence the Stopwatch. Setting the interval of timSlideShow this low guarantees enough precision for a slide show. This is as precise as the current version.

I decided to not append milliseconds to the label on the screen, I found it to be too much clutter for the eye. If you decide to append it, the string's format should be mm':'ss'.'fff. (L2332, frmMain.cs)

Ben

@d2phap d2phap merged commit f78ed7e into d2phap:develop Jul 26, 2022
@d2phap
Copy link
Owner

d2phap commented Jul 26, 2022

Thanks @BenHUET!

@d2phap d2phap added this to the v8.7 milestone Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants