Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select the largest frame of ICO files #994

Closed
db-one opened this issue Mar 3, 2021 · 13 comments
Closed

Select the largest frame of ICO files #994

db-one opened this issue Mar 3, 2021 · 13 comments

Comments

@db-one
Copy link

db-one commented Mar 3, 2021

image

Hi, can you add support for ICO icon files, for example, this icon contains seven icons of different sizes. If you use the WINDOWS default file manager, you can browse the seven icons separately, but ImageGlass can only display the first one by default , And some icons are displayed abnormally, such as the following, so can you add a button to switch the icons in the ICO file and browse normally, thank you very much

snipaste20210303_195438

@d2phap
Copy link
Owner

d2phap commented Mar 3, 2021

You can use Page Navigation tool:
image

@db-one
Copy link
Author

db-one commented Mar 4, 2021

Okay, thank you very much

@db-one
Copy link
Author

db-one commented Mar 4, 2021

image

image

For example, the size of the image opened by ImageGlass will be displayed incompletely as shown below. Below is the original file of the icon for reference, thank you

image

SonyMDRV700.zip
photos.zip

@K0media
Copy link

K0media commented Apr 9, 2021

@d2phap, acutally, I'm having an issue about how the icons are handled.
Please see below:

ImageGlass.Icon.Handling.mp4

What can be done about this? Any workarounds or it works that way?
Is there another issue open regarding this problem? I thought of opening an issue, but I think it would be a duplicate.

Is it going to be fixed by default any time soon?

Thanks.

@fire-eggs
Copy link
Collaborator

@K0media :

acutally, I'm having an issue about how the icons are handled. Please see below:

Could you state what your actual issue is? I see you clicking on what are presumably icon files, zooming in and out, and clicking on another icon.

What is it about the ImageGlass behavior which is unacceptable?

@K0media
Copy link

K0media commented Apr 9, 2021

@K0media :

acutally, I'm having an issue about how the icons are handled. Please see below:

Could you state what your actual issue is? I see you clicking on what are presumably icon files, zooming in and out, and clicking on another icon.

What is it about the ImageGlass behavior which is unacceptable?

It's simple. It is handled abnormally by IG, while it displays fine on other media viewers.

I'll record another screencast to show you. (I'd record a video with audio explaining details, but that would take longer. I can do it if necessary later, though.)

ImageGlass.Icon.Handling.and.Windows.App.mp4

As you can see above, some icons display fine in "normal" resolution, but some others are distorted and pixelated that we almost can't see the proper format.

And, when opening with another app, such as Windows 10 default Photos app, it displays fine with the anti-aliasing effect.

There should be something wrong here... I tried customizing options, but it's still mishandled by IG.

Also, I can share the icon pack if needed, so you can research better on it.

@d2phap
Copy link
Owner

d2phap commented Apr 9, 2021

@K0media
You can change Zoom Optimization option to Smooth pixels (in v8.0), or Low quality (in v8.1) in Settings > Image > Zooming

@fire-eggs
Copy link
Collaborator

fire-eggs commented Apr 9, 2021

Right, I understand now. Thanks for the detailed videos!

TLDR; sorry to say but this is the current state of ImageGlass, no workarounds possible.

Some of these other apps presumably are taking advantage of the different sized icons contained in the ICO. [E.g. as you zoom in, the apps use the next larger icon file as necessary.] ImageGlass (currently) does not: the first, smallest icon file is the only one used and zooming just gets big pixels.

I'm not quite sure what's going on with the anti-aliasing. I.e. is that a feature of the other media apps or something in the newest icon formats that I'm unaware of? Either way, ImageGlass isn't currently supporting it.

OK, from wikipedia:

The Windows Vista Explorer supports smoothly scaling icons to non-standard sizes which are >rendered on the fly even if an image is not present for that size in the icon file.

ImageGlass is not doing this.

@iDm1
Copy link

iDm1 commented Apr 17, 2021

I think you're overcomplicating how other viewers are handling ICO files. This format usually contains several different images for different sizes. Most image viewers are displaying the largest of them by default, but ImageGlass always displays the first one, which is often the smallest one.

Displaying the largest image from ICO file by default is enough. Dynamic switching to the closest size is nice of course, but it requires much more changes in ImageGlass to implement it.

@db-one
Copy link
Author

db-one commented Apr 18, 2021

I think you're overcomplicating how other viewers are handling ICO files. This format usually contains several different images for different sizes. Most image viewers are displaying the largest of them by default, but ImageGlass always displays the first one, which is often the smallest one.

Displaying the largest image from ICO file by default is enough. Dynamic switching to the closest size is nice of course, but it requires much more changes in ImageGlass to implement it.

Yes, Strongly Agree

@fire-eggs
Copy link
Collaborator

Most image viewers are displaying the largest of them by default, but ImageGlass always displays the first one, which is often the smallest one.

My thanks for the feedback! My ignorance of the ICO format is showing ...

@d2phap d2phap changed the title Hi, can you add support for ICO icon files Select the largest frame of ICO files May 15, 2021
@d2phap d2phap added this to the Issues 8.1 milestone May 15, 2021
@d2phap
Copy link
Owner

d2phap commented May 15, 2021

I spent my time today to refactor the code for ICO file, so now IG will display the largest frame of the viewing ICO file by default.
However, the problem with displaying (picture below) is not fixed. ImageGlass is using Magick.NET for loading ICO, apparently Magick.NET has issue with this ico file.

This change will be included in the next official release (soon).

image

@d2phap
Copy link
Owner

d2phap commented May 16, 2021

released v8.2!

@d2phap d2phap closed this as completed May 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants