Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image (still) gets corrupted after rotating #1097

Closed
dw-0 opened this issue Jun 14, 2021 · 11 comments
Closed

Image (still) gets corrupted after rotating #1097

dw-0 opened this issue Jun 14, 2021 · 11 comments
Assignees
Milestone

Comments

@dw-0
Copy link

dw-0 commented Jun 14, 2021

System information:

  • Windows OS version: Win 10 Pro x64
  • ImageGlass version: 8.2.6.6 x64 Portable

To Reproduce

Steps to reproduce the behavior:

  1. Open Image with ImageGlass
  2. Enable "Save the viewing image after rotating" in the Edit-Settings
  3. Rotate the image either left or right
  4. Close the window and make ImageGlass save the new orientation
  5. File is now corrupted

Actual behavior:

After describing the behaviour of the earlier version here: #1096
The behaviour is almost the same. But it seems that i can pin down the issue to the auto file saving after rotation.
EDIT: so basically the bug described here still applies: #1033

I closed the other issue after i saw in the changelog, that the issue got fixed and downloaded the newest release. I then immediately tried to rotate the test image and it got corrupted again.

I then deleted the whole ImageGlass folder where i store my settings too and decided to start over from scratch with a clean "install". After that, rotating worked when i had to save the image manually afterwards. Then i toggled the auto save after rotating. And there we go again... the image got corrupted again.

Expected behavior:

No corrupted image after saving

Screenshots:

I recorded my screen again, showing the actual procedure. First with rotating and saving manually. Then toggling the auto-save option which then leads to the file-corruption.
Bild bug_still_presenthgjr4.gif auf abload.de

@fire-eggs
Copy link
Collaborator

I'm pretty sure, just looking at the GIF and the archive attached to #1096, the problem is due to IG shutting down during the save process. I.e. the same problem as issue #566.

Sometimes your save will succeed, depending on who "wins": app shutdown or save-file.

Ideally, IG should stay running (but invisible) until async tasks like file save finish.

@d2phap d2phap added this to the Issues 8.3 milestone Jan 12, 2022
d2phap added a commit that referenced this issue Jan 12, 2022
@d2phap
Copy link
Owner

d2phap commented Jan 12, 2022

Please try the latest build of IG Moon which is to attempts to fix this issue.
https://imageglass.org/moon
Note that, the thumbnail bar is flashing when the app is busy, I will fix later.

@d2phap d2phap closed this as completed Jan 16, 2022
@AndyHarbage
Copy link

AndyHarbage commented Mar 19, 2022

Still getting this bug. I've just installed ImageGlass 8.5.1.22 (x64). Using Rotate + Auto Save option corrupted several of my large (apprx 100mb) .png files. Including ones I wasn't even rotating. Just navigating through images caused the save message appear erroneously for images I wasn't even changing and corrupt some of my images. Meaning I'm no longer able to open them, as there's only half an image left.

Windows 11 21H2.

@SillyCatto
Copy link

SillyCatto commented Jul 19, 2022

Im facing the same problem. Enabled "Save the viewing image after rotating" in the Edit-Settings, rotated an image and its corrupted.

Image glass version 8.6.7.13
Windows 10 21H2

ig

@Catfriend1
Copy link

I also have this problem with the corruption after rotate and pressing left/right cursor keys.
Plus, today I've had three JPG of a book's page. Page 1...3. ImageGlass wrote the content of page3.jpg into page2.jpg. Had a backup copy of the original scans and then noticed, page2.jpg really contained page2 and ImageGlass saved to the wrong file name what was rotated/shown for page 3.

@Catfriend1
Copy link

Thanks for reopening the ticket.

@masterofobzene
Copy link

masterofobzene commented Feb 24, 2023

Is this still happening? it was reported more than two years ago... basic functionality.
The program seems to be having updates, name changes... but this bug is still there?

"qimgv" photo viewer seems to have done this right, why don't you Dev ask him how he did it?

@Catfriend1
Copy link

Yes, the bug is still there.

@d2phap
Copy link
Owner

d2phap commented Mar 17, 2023

This issue should be fixed in the latest build of ImageGlass Moon 8.7: https://imageglass.org/moon.

The saving behaviors are also changed:

  • When user make a change to the viewing image, ImageGlass will show a warning message when they want to override it.
  • When user make a change to the viewing image and then exit the app, or view another image, ImageGlass will show a prompt to ask user if they want to save the change or not.

image

image

@Catfriend1
Copy link

Good Job! Thank you.

@masterofobzene
Copy link

Why did you include a nag screen instead of just making those warnings on the main page?

@d2phap d2phap closed this as completed Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants