Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capture INFO and WARN from tracing by default #54

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Capture INFO and WARN from tracing by default #54

merged 1 commit into from
Jan 13, 2025

Conversation

Wilfred
Copy link
Contributor

@Wilfred Wilfred commented Jan 8, 2025

Previously, we only captured ERROR, and required users to set RUST_LOG=info explicitly when running tests.

Fixes #53

@Wilfred
Capture INFO and WARN from tracing by default
5ccb43f 
Previously, we only captured ERROR, and required users to set
RUST_LOG=info explicitly when running tests.

Fixes d-e-s-o#53
d-e-s-o
d-e-s-o reviewed Jan 13, 2025
View reviewed changes
Copy link
Owner

@d-e-s-o d-e-s-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. This seems fine for tracing, but I think we need something similar for the log part. Can you look into that?

@d-e-s-o
Copy link
Owner

d-e-s-o commented Jan 13, 2025

Nevermind, I think I found a way. Will add it.

@d-e-s-o d-e-s-o merged commit a98f548 into d-e-s-o:main Jan 13, 2025
@Wilfred Wilfred deleted the tracing_info branch January 13, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-e-s-o d-e-s-o d-e-s-o left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RFC: Set the default log level to INFO
2 participants
@Wilfred @d-e-s-o