fix: append #[::core::prelude::v1::test] only if it does not exist
#46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way if preceding test macros add `#[::core::prelude::v1::test]` by appending, then we can avoid duplicated test runs. See also frondeus/test-case#101, frondeus/test-case#143 Closes d-e-s-o#35.
d-e-s-o
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
Thanks for the proposal! I am fine with the approach. Left a few nitpicks.
This pr depends on frondeus/test-case#143 and tokio-rs/tokio#6497.
Can we please wait until these are merged? I'd rather not include any temporary patches.
|
@d-e-s-o Thank you for reviewing. I am good with the merge timing. I have pushed with a fixup commit to solve your concerns. Also, I checked that there is no duplicated test runs for new test cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way if preceding test macros add
#[::core::prelude::v1::test]by appending, then we can avoid duplicated test runs.See also frondeus/test-case#101, frondeus/test-case#143
Closes #35.
This pr depends on frondeus/test-case#143 and tokio-rs/tokio#6497.