Add --only-aes-key option to reset command #149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds an --only-aes-key option to the reset command to only build a new AES key without performing a full factory reset. Fixes d-e-s-o#69.
|
Nevermind, applying the same workaround as for the regular password reset helped. |
|
Thanks for the pull request, Robin! I'll take a closer look at this and your other work later this week. Running a bit thing right now. |
|
Great work! Merged this one, too, but I am a bit confused by your usage of "admin PIN" in the test. I think you meant user PIN and changed it, but perhaps I am missing something. |
|
You’re totally right. I started out using the admin PIN before I realized that we need the user PIN to enable the PWS and then forgot to fix the comment. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds an --only-aes-key option to the reset command to only
build a new AES key without performing a full factory reset.
Fixes #69.
Unfortunately, I can’t get the new unit test to work. I get a Wrong Password error for the reset call. But if I manually execute the command, it’s working fine. Can you confirm this problem? Do you see the reason for the error?