Skip to content

Conversation

@aboulfad
Copy link
Contributor

Change ARP_QUEUEING to 1, details in issue #3481 of Arduino repo.

Change ARP_QUEUEING to 1, details in issue #3481
@d-a-v d-a-v merged commit 82abda3 into d-a-v:master Apr 11, 2019
Copy link
Owner

@d-a-v d-a-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing that bug !

@someburner
Copy link
Contributor

@d-a-v

Should this also be enabled for open-sdk lwipopts.h?

@d-a-v
Copy link
Owner

d-a-v commented May 3, 2019

@someburner
Yes of course.

I was only looking at my esp-open-sdk ongoing obsolete PR,
I wasn't aware of your repository https://github.com/someburner/esp-open-sdk/tree/sdk2-lwip212.
Will you make a PR on esp-open-sdk from yours ?

I will update the ARP thing for esp-open-sdk to avoid a PR here.

(edit: done)

@aboulfad
Copy link
Contributor Author

aboulfad commented May 3, 2019

@d-a-v , I've sent you a follow up email sometime ago after the PR, that the builder link in https://github.com/esp8266/Arduino/tree/master/tools/sdk/lwip2 is still wrong and points to a previous version, I've resent the email now.

@d-a-v
Copy link
Owner

d-a-v commented May 3, 2019

@aboulfad You seem to be right. Arduino repository doesn't point to the right commit.

@someburner
Copy link
Contributor

@d-a-v

Thanks. I haven't made the PR to esp-open-sdk yet since pfalcon hasn't provided any guidance on what to do about sntp, but I could ask again. I have my own SDK in order to use more recent versions of GCC.

@d-a-v
Copy link
Owner

d-a-v commented May 4, 2019

Is it the esp-sntp.c ? We can put it back here if needed but I guess you have one for your repository
Per pfalcon/esp-open-sdk#271 (comment) I think you'd just need to use them (esp-sntp.c, esp-millis.c) in the open Makefiles and prpose a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants