Tabula muris clean up #170
Conversation
README.md
Outdated
| @@ -225,5 +225,5 @@ tabula_muris/ | |||
| From Guoji Guo's lab at Zhejiang University School of Medicine in China | |||
|
|
|||
| - [MCA Data Analysis](https://github.com/ggjlab/mca_data_analysis) | |||
| - [scMCA](https://github.com/ggjlab/scMCA) - An simple R package for large scale data (large DGE) from Mouse Cell Atlas ,to alleviate burdens of our main Server | |||
| - [scMCA](https://github.com/ggjlab/scMCA) - An simple R package for large scale data (large DGE) from Mouse Cell Atlas, to alleviate burdens of our main Server | |||
There was a problem hiding this comment.
This description is from them, doesn't make much sense here (what is "our main Server"?)
There was a problem hiding this comment.
Agreed, I'll simplify that
| writeData(wb, sheet = sheetname, dataframe,rowNames = FALSE) | ||
| } | ||
|
|
||
| saveWorkbook(wb,paste0(tissue,".xlsx"),overwrite = TRUE) |
There was a problem hiding this comment.
Looks like this should be two spaces in as far as indentation goes.
| ``` | ||
|
|
||
| ```{r} | ||
| library(openxlsx) |
There was a problem hiding this comment.
I'm not up to speed on the recent changes to this project overall so this might be a silly questions: what is the reason to list cell type markers by using an excel workflow?
If we do want to allow an excel workbook would we also want to support csv or another format? If not then ignore the rest, otherwise I would probably split this function to one that creates a dataframe with the needed values and returns that. Then create a separate function that would create an excel workbook given that dataframe. Then if someone wanted to write csvs or just explore the dataframe the function can be used for those purposes. Again this might not make any sense given the use case.
to the best of my knowledge this is now part of paper supplement and we don't need this file in the repo if you'd rather keep it then needs updating
…thods.md Delete computational_methods.md
in progress repo cleaning - stay tuned!