Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code formatting #8

Closed
ziw-liu opened this issue Nov 29, 2022 · 0 comments · Fixed by #14
Closed

Code formatting #8

ziw-liu opened this issue Nov 29, 2022 · 0 comments · Fixed by #14
Labels
enhancement New feature or request meta About how we organize the project
Milestone
0.1.0

Comments

@ziw-liu
Copy link
Collaborator

ziw-liu commented Nov 29, 2022 •
edited
Loading

Although hints of code formatting exist, no formatting has been consistently enforced in this repo:
https://github.com/czbiohub/iohub/blob/641922e9851b59b0309532c933c4156ac699e99f/pyproject.toml#L8-L13

We can refer to mehta-lab/recOrder#176 and mehta-lab/recOrder#229 on how to adopt formatting while preserving Git history.

I lean towards using the existing formatting spec (black with max line length of 79), but open to suggestions.
@ziw-liu ziw-liu added enhancement New feature or request meta About how we organize the project labels Nov 29, 2022
@ziw-liu ziw-liu added this to the 0.0.1 milestone Dec 2, 2022
@ziw-liu ziw-liu mentioned this issue Dec 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request meta About how we organize the project
Projects
None yet
Milestone
0.1.0
Development

Successfully merging a pull request may close this issue.

Black formatting czbiohub-sf/iohub
1 participant
@ziw-liu