-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test workflow is outdated #5
Comments
We could also add pre-commit |
Was about to open a separate issue to propose the introduction of formatting/linting. |
With #25 I think we still need testing on multiple platforms. |
Another thought about CI: #31 (comment) |
We can definitely add multiple platforms testing but I would question the need. Do we have any dependency that is behaving different across different platforms? Or do we write any such code?
I would be happy to run codecov on main branch whenever a new PR is merged(and have a coverage badge on readme maybe?). For the PR CI runs, I would suggest adding codecov as a final step task since it is running tests significantly slower. |
By testing we can ensure that the code does not behave differently due to unintended practice such as hardcoding slashes when joining filenames.
I agree! |
Removing from 0.1.0 milestone since #25 fixed most of the more urgent issues. |
Currently the GH Action only tests the package on Linux (Ubuntu) and Python 3.7 (which is EOL). We should test on more platforms (Windows and macOS) and newer Python versions (3.8+).
We can also add coverage check and linting to the PR-triggered workflows.
The text was updated successfully, but these errors were encountered: