Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test workflow is outdated #5

Closed
ziw-liu opened this issue Nov 28, 2022 · 7 comments · Fixed by #108
Closed

Test workflow is outdated #5

ziw-liu opened this issue Nov 28, 2022 · 7 comments · Fixed by #108
Assignees
Labels
CI Continuous integration

Comments

@ziw-liu
Copy link
Collaborator

ziw-liu commented Nov 28, 2022

Currently the GH Action only tests the package on Linux (Ubuntu) and Python 3.7 (which is EOL). We should test on more platforms (Windows and macOS) and newer Python versions (3.8+).

We can also add coverage check and linting to the PR-triggered workflows.

@ziw-liu ziw-liu added the enhancement New feature or request label Nov 28, 2022
@ziw-liu ziw-liu added this to the 0.0.1 milestone Nov 28, 2022
@ziw-liu ziw-liu self-assigned this Nov 28, 2022
@JoOkuma
Copy link
Member

JoOkuma commented Nov 29, 2022

We could also add pre-commit

@ziw-liu
Copy link
Collaborator Author

ziw-liu commented Nov 29, 2022

We could also add pre-commit

Was about to open a separate issue to propose the introduction of formatting/linting.

@ziw-liu
Copy link
Collaborator Author

ziw-liu commented Feb 1, 2023

With #25 I think we still need testing on multiple platforms.

@ziw-liu
Copy link
Collaborator Author

ziw-liu commented Feb 2, 2023

Another thought about CI: #31 (comment)
Maybe something like Codecov?

@AhmetCanSolak
Copy link
Contributor

With #25 I think we still need testing on multiple platforms.

We can definitely add multiple platforms testing but I would question the need. Do we have any dependency that is behaving different across different platforms? Or do we write any such code?

Another thought about CI: #31 (comment) Maybe something like Codecov?

I would be happy to run codecov on main branch whenever a new PR is merged(and have a coverage badge on readme maybe?). For the PR CI runs, I would suggest adding codecov as a final step task since it is running tests significantly slower.

@ziw-liu
Copy link
Collaborator Author

ziw-liu commented Feb 7, 2023

Do we have any dependency that is behaving different across different platforms? Or do we write any such code?

By testing we can ensure that the code does not behave differently due to unintended practice such as hardcoding slashes when joining filenames.

For the PR CI runs, I would suggest adding codecov as a final step task since it is running tests significantly slower.

I agree!

@ziw-liu
Copy link
Collaborator Author

ziw-liu commented Feb 23, 2023

Removing from 0.1.0 milestone since #25 fixed most of the more urgent issues.

@ziw-liu ziw-liu removed this from the 0.1.0 milestone Feb 23, 2023
@ziw-liu ziw-liu added CI Continuous integration and removed enhancement New feature or request labels Feb 24, 2023
@ziw-liu ziw-liu linked a pull request Apr 17, 2023 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants