-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Array-like API for NGFF I/O #19
Comments
This is beautiful and I would suggest us to adopt datasets and drop support for |
I'm in favor of immediately dropping support for I'm a bit more conservative about dropping support for the current |
I see your point and I am with you @talonchandler . We don't need to drop readers immediately but maybe we can provide a keyword argument to datasets which can allow you to call the legacy readers underneath temporarily. This way we can keep the readers as part of private API for some time and start promoting the dataset array API immediately. How would you feel about such direction? |
Sounds great to me! |
In contrast to the readers/writers design inherited from
waveorder.io
, a 'dataset' container for NGFF datasets that offers array-like API is more ergonomic and pythonic for NGFF datasets. It is also more maintainable since the data and metadata models can stay in one place.Pseudo code aggregated from our offline discussion:
The text was updated successfully, but these errors were encountered: