Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test on NDTIFFv3 datasets #149

Open
ziw-liu opened this issue Jun 20, 2023 · 1 comment
Open

Test on NDTIFFv3 datasets #149

ziw-liu opened this issue Jun 20, 2023 · 1 comment
Labels
CI Continuous integration μManager Micro-Manager files and metadata

Comments

@ziw-liu
Copy link
Collaborator

ziw-liu commented Jun 20, 2023

Currently the NDTIFF reader is only tested on v2 datasets, leading to issues like #124 (comment). The new v3 datasets should be added to the pool for coverage on recent data.
@ziw-liu ziw-liu mentioned this issue Jun 20, 2023
Merged
@ziw-liu ziw-liu added μManager Micro-Manager files and metadata CI Continuous integration labels Jun 20, 2023
@ziw-liu
Copy link
Collaborator Author

ziw-liu commented Jul 25, 2023

@ieivanov pointed out that we can just use https://github.com/micro-manager/NDTiffStorage/tree/main/test_data/v3. Since the NDTIFF reader is a very thin wrapper we can also reduce the number of dataset we test on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Continuous integration μManager Micro-Manager files and metadata
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ziw-liu