Caldav/Carddav admin html page: enable editing DAV:displayname #5024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dilyanpalauzov
force-pushed
the
delete_http_carddav_js
branch
from
defa060
to
25c131e
Compare
dilyanpalauzov
force-pushed
the
delete_http_carddav_js
branch
from
25c131e
to
87156ba
Compare
|
This looks good. I think we would want to rename http_caldav.js to http_calcarddav.js or maybe even http_cal_abook.js |
Renaming http_caldav.js can be done later. |
dilyanpalauzov
force-pushed
the
delete_http_carddav_js
branch
from
87156ba
to
ab9315d
Compare
to enable editing the properties over AJAX. - merge imap/http_carddav.js into imap/http_caldav.js and make the latter more generic, in order to serve both CalDAV and CardDAV administration. - all calendars are numbered in the generated HTML, starting from zero and each JavaScript function receives as parameter the calendar/addressbook number, on which to enact an action.
dilyanpalauzov
force-pushed
the
delete_http_carddav_js
branch
from
ab9315d
to
20f50cb
Compare
ksmurchison
approved these changes
Sep 19, 2024
dilyanpalauzov
added a commit
to dilyanpalauzov/cyrus-imapd
that referenced
this pull request
Sep 24, 2024
IN UPSTREAM - part of cyrusimap#5024 NOT IN 3.10 to enable editing the properties over AJAX. - merge imap/http_carddav.js into imap/http_caldav.js and make the latter more generic, in order to serve both CalDAV and CardDAV administration. - all calendars are numbered in the generated HTML, starting from zero and each JavaScript function receives as parameter the calendar/addressbook number, on which to enact an action.
dilyanpalauzov
added a commit
to dilyanpalauzov/cyrus-imapd
that referenced
this pull request
Sep 24, 2024
IN UPSTREAM NOT IN 3.10 PART OF cyrusimap#5024
dilyanpalauzov
pushed a commit
to dilyanpalauzov/cyrus-imapd
that referenced
this pull request
Sep 24, 2024
IN UPSTREAM NOT IN 3.10 PART OF cyrusimap#5024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have some changes to the generated admin pages, which enable editing WebDAV properties.
The current, first part reorganizes list_calendars() and list_addressbooks() to enable editing the properties over AJAX.
I think I have switched away from passing displayname to JavaScript functions, because its content must be HTML-escaped to work reliably, but is not - cf. #3389.