Resolve clang-tidy warnings for Xapian wrapper #5017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once we are done with the clang-tidy changes, let's get back to #2818 and see if there is anything in there that's not addressed already. |
rsto
force-pushed
the
clang_tidy_xapian_wrap
branch
from
0954592
to
85a513c
Compare
elliefm
reviewed
Sep 5, 2024
rsto
force-pushed
the
clang_tidy_xapian_wrap
branch
5 times, most recently
from
2c932df
to
5d53b57
Compare
|
I have updated this PR description, this PR only is meant to fix issues found by the |
ksmurchison
approved these changes
Sep 12, 2024
elliefm
reviewed
Sep 13, 2024
rsto
force-pushed
the
clang_tidy_xapian_wrap
branch
from
5d53b57
to
d94aac2
Compare
elliefm
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Xapian wrapper code in
imap/xapian_wrap.cppis anything but idiomatic or modern C++ code. #2818 highlights some of that, but we didn't act on it timely and the code now is stale. It also didn't help that the code changes are all in a single commit.This PR attempts to sanitize the C++ code in smaller steps. As a baseline of what constitutes "sane C++" code, we'll start with the clang-tidy linter with the
bugpronecheck category.I am using this with Debian LLVM version 14.0.6.