Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JMAP contacts support to IETF standards #4479

Merged
merged 169 commits into from
Oct 9, 2023
Merged

Conversation

@ksmurchison ksmurchison requested a review from rsto April 13, 2023 16:48
@ksmurchison ksmurchison marked this pull request as draft April 13, 2023 16:48
@ksmurchison ksmurchison force-pushed the jmap_contacts_ietf branch 5 times, most recently from e0990d5 to 112ef46 Compare April 27, 2023 15:00
@ksmurchison ksmurchison force-pushed the jmap_contacts_ietf branch 4 times, most recently from a039f78 to 838cfae Compare May 2, 2023 16:50
@ksmurchison ksmurchison force-pushed the jmap_contacts_ietf branch 3 times, most recently from 79af45a to 4084d70 Compare May 10, 2023 17:17
@ksmurchison ksmurchison force-pushed the jmap_contacts_ietf branch 3 times, most recently from cade6dd to c2d8066 Compare May 18, 2023 11:38
@ksmurchison ksmurchison force-pushed the jmap_contacts_ietf branch 2 times, most recently from e546e06 to 8a35ca7 Compare May 28, 2023 13:06
@ksmurchison ksmurchison force-pushed the jmap_contacts_ietf branch 2 times, most recently from a00fbf6 to ecb0bf1 Compare June 9, 2023 11:45
@ksmurchison ksmurchison marked this pull request as ready for review June 12, 2023 18:40
@ksmurchison ksmurchison changed the title WIP: Update JMAP contacts support to IETF standards Update JMAP contacts support to IETF standards Jun 12, 2023
@ksmurchison ksmurchison force-pushed the jmap_contacts_ietf branch 3 times, most recently from 89d49a9 to e301bd7 Compare July 26, 2023 15:11
ksmurchison and others added 24 commits October 5, 2023 07:17
@ksmurchison ksmurchison merged commit d94f5a3 into master Oct 9, 2023
0 of 2 checks passed
@elliefm
Copy link
Contributor

elliefm commented Oct 10, 2023

This was merged with failing CI checks 👎

@ksmurchison
Copy link
Contributor Author

What's failing?

@elliefm
Copy link
Contributor

elliefm commented Oct 10, 2023

Should be fixed by #4684 -- will find out when its checks finish...

@elliefm
Copy link
Contributor

elliefm commented Oct 10, 2023

It introduced a dependency on XML::Simple, which neither the docker image nor the workflow script was installing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants