imapd.c:cmd_sync…(): avoid double checking for imapd_userisadmin #3572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cmd_syncapply(), cmd_syncget() and cmd_syncrestore() functions check, whether imapd_userisadmin, so the same check is not necessary, before these functions are called. Insisting on “DCO” imposes formalities, that end it theirselves. One cannot assume that the committer understands English, or that the submitter has time or will to read texts about symbolism in software contributions. If the system wants to see the text nrEAUIEUAIe eEEAIUEAUEAEUAI eauaieeuai »ℓ§444.3.72b)°»°ℓ§euaieauuae in each commit, people will write this, or any other text, that the system wants to see. All such text, which presense is mandated by the system, has the same value. Signed-off-by: Дилян Палаузов <[email protected]>
|
Superseded by #5039 |
dilyanpalauzov
added a commit
to dilyanpalauzov/cyrus-imapd
that referenced
this pull request
Sep 24, 2024
The cmd_syncapply() function repeats the check, performed in cmdloop(). cyrusimap#3572
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cmd_syncapply(), cmd_syncget() and cmd_syncrestore() functions check, whether imapd_userisadmin, so the same check is not necessary, before these functions are called.